Skip to content

fix: clean rebuild of PR #1188 maintainability remediation#1213

Merged
BigSimmo merged 16 commits into
mainfrom
cursor/pr1188-fix-build-breakers-6ee0
Jul 25, 2026
Merged

fix: clean rebuild of PR #1188 maintainability remediation#1213
BigSimmo merged 16 commits into
mainfrom
cursor/pr1188-fix-build-breakers-6ee0

Conversation

@BigSimmo

@BigSimmo BigSimmo commented Jul 25, 2026 •
edited by cursor Bot
Loading

Copy link
Copy Markdown
Owner

Summary

Clean rebuild of the maintainability remediation intended by PR #1188, applied on current main instead of the broken execute-audit-remediation-plan tip.

Do not merge PR #1188 (already closed as superseded). Tip 8b863911 was syntax-broken and ~469 behind main.

This PR keeps the intentional remediation only:

  • Extract SystemNotice / DegradedNotice to dashboard-notices.tsx with visibility parity
  • Lazy-load admin tools via clinical-dashboard-lazy.tsx
  • Extract indexing-v3-agent string/label helpers to utils.ts
  • Drop unused utils re-imports left after extraction
  • Small check-github-action-pins.mjs cleanup helper
  • Fix Sheet autofocus upgrade from close-button fallback when lazy data-sheet-autofocus mounts (unblocks Production UI Sources “Find a document” focus)

RAG impact: no retrieval behaviour change — refactor only.

Verification

  • tsc --noEmit pass on rebuild tip
  • node --check supabase/functions/indexing-v3-agent/utils.ts
  • npm run check:github-actions pass
  • Focused Vitest + ledger guard pass
  • ESLint clean on indexing-v3-agent/index.ts
  • Hosted CI: waiting on tip c45189c76 after Sheet autofocus fix (prior tip failed one Sources autofocus UI smoke)
  • UI verification not run locally; hosted Production UI is the gate

Risk and rollout

  • Risk: Low — extract/lazy-load + Sheet focus retry upgrade
  • Rollback: Revert this PR
  • Provider or production effects: None

Clinical Governance Preflight

  • Source-backed claims still require linked source verification before clinical use
  • No patient-identifiable document workflow was introduced or expanded without explicit governance approval
  • Supabase target remains Clinical KB Database (sjrfecxgysukkwxsowpy)
  • Service-role keys and private document access remain server-only
  • Demo/synthetic content remains clearly separated from real clinical sources
  • Source metadata, review status, and outdated/unknown-source behavior remain conservative
  • Deployment classification/TGA SaMD impact was checked when clinical decision-support behavior changed — N/A (no CDS behaviour change)

Notes

Open in Web Open in Cursor 

@BigSimmo
fix: rebuild PR #1188 maintainability remediation on clean main
183291a 
Replace the broken execute-audit-remediation-plan tip (conflict markers,
orphaned ClinicalDashboard import, async export syntax, missing
CLINICAL_PHRASE_PATTERN) with a main-based extraction that keeps notice
visibility parity and lazy-loads admin tools via clinical-dashboard-lazy.
@coderabbitai

coderabbitai Bot commented Jul 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@BigSimmo, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 18 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 8c3834da-d937-464c-813c-4627b46af4da

📥 Commits

Reviewing files that changed from the base of the PR and between 8ec2a3c and 1da124b.

📒 Files selected for processing (10)
  • docs/branch-review-ledger.md
  • scripts/check-github-action-pins.mjs
  • scripts/decompose-indexing-v3.mjs
  • src/components/ClinicalDashboard.tsx
  • src/components/clinical-dashboard/clinical-dashboard-lazy.tsx
  • src/components/clinical-dashboard/dashboard-notices.tsx
  • src/components/ui/sheet.tsx
  • supabase/functions/indexing-v3-agent/index.ts
  • supabase/functions/indexing-v3-agent/utils.ts
  • tests/ui-smoke.spec.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cursor/pr1188-fix-build-breakers-6ee0

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@supabase

supabase Bot commented Jul 25, 2026 •
edited
Loading

Copy link
Copy Markdown

Updates to Preview Branch (cursor/pr1188-fix-build-breakers-6ee0) ↗︎

Deployments Status Updated
Database ✅ Sat, 25 Jul 2026 16:15:44 UTC
Services ✅ Sat, 25 Jul 2026 16:15:44 UTC
APIs ✅ Sat, 25 Jul 2026 16:15:44 UTC

Tasks are run on every commit but only new migration files are pushed.
Close and reopen this PR if you want to apply changes from existing seed or migration files.

Tasks Status Updated
Configurations ✅ Sat, 25 Jul 2026 16:15:45 UTC
Migrations ✅ Sat, 25 Jul 2026 16:15:48 UTC
Seeding ✅ Sat, 25 Jul 2026 16:15:50 UTC
Edge Functions ✅ Sat, 25 Jul 2026 16:15:53 UTC

View logs for this Workflow Run ↗︎.
Learn more about Supabase for Git ↗︎.

@cursor cursor Bot mentioned this pull request Jul 25, 2026
Closed
@BigSimmo
BigSimmo marked this pull request as ready for review July 25, 2026 15:31
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Jul 25, 2026

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@github-actions

github-actions Bot commented Jul 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

CI triage

CI failed on this PR. Automated classification of the 2 failed job(s):

  • Production UI — needs investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.
  • PR required — needs investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.

Compared with main CI run #5589 (success).

Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger.

@BigSimmo
BigSimmo merged commit 8e3a49d into main Jul 25, 2026
18 checks passed
@BigSimmo
BigSimmo deleted the cursor/pr1188-fix-build-breakers-6ee0 branch July 25, 2026 16:24
@BigSimmo BigSimmo mentioned this pull request Jul 25, 2026
Merged
1 task
BigSimmo added a commit that referenced this pull request Jul 25, 2026
@BigSimmo
docs: record PR #1213 prlanded merge superseding #1188 (#1225)
55ce252 
Append-only ledger row for the #1213 land / #1188 supersede.
This was referenced Jul 25, 2026
Merged
Merged
@BigSimmo BigSimmo mentioned this pull request Jul 25, 2026
Merged
2 tasks
@cursor cursor Bot mentioned this pull request Jul 26, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@BigSimmo